Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 4, 2024

There is not much point in using .unwrap() when all callers can easily use the ? operator...

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 4, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) October 4, 2024 15:26
@Turbo87 Turbo87 merged commit 5a4f484 into rust-lang:main Oct 4, 2024
8 checks passed
@Turbo87 Turbo87 deleted the unwrap branch October 4, 2024 15:36
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (cf322b4) to head (ab97990).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/admin/transfer_crates.rs 0.00% 3 Missing ⚠️
src/admin/delete_crate.rs 0.00% 1 Missing ⚠️
src/admin/delete_version.rs 0.00% 1 Missing ⚠️
src/admin/dialoguer.rs 0.00% 1 Missing ⚠️
src/admin/upload_index.rs 0.00% 1 Missing ⚠️
src/admin/yank_version.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9584   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         289      289           
  Lines       29118    29117    -1     
=======================================
  Hits        25892    25892           
+ Misses       3226     3225    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant